Only trigger CI on .py file changes
#131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
In general the CI is currently an issue in general since it can't be used for PRs for forks, so it's in a sort of limbo. The plan is to re-do the whole thing in GCP and create a constantly running runner which will be shared with other HF projects with occasional CI needs like accelerate. In general your proposal is sensible, but it'll miss for example checking if updated requirements break something. Please feel free to merge, as it's mostly not being run anyway as most users do forked PRs. |
Member
Author
|
Sounds good! I'll merge for now and maybe we can revisit this later when things have completely been migrated to GCP. Thanks! |
adammoody
pushed a commit
to adammoody/Megatron-DeepSpeed
that referenced
this pull request
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the CI seems to run on every PR. While this is a safe way to ensure that all tests pass, a more sensible rule might be to trigger the pipeline only when material changes are made to the code base, i.e., when a
.pyfile is modified or pushed.